Issue link

Closes project-codeflare/instascale#66

What changes have been made

An e2e test has been added to test the entire instascale flow on an OSD Cluster.

Verification steps

• Provision an OSD cluster
• Install the codeflare stack following the Quick Start and ensuring you follow the specific instructions here.
• A NodeFeatureDiscovery CR and ClusterPolicy CR are required also. These can be added using the updated makefile - if installing using make all-in-one these should already be present. NFD and ClusterPolicy.
• Using VS Code provide the cluster ID in a .vscode/settings.json file like this

{
   "go.testEnvVars": {
       "CLUSTERID": "261l6dk6frpvmt49csi90uhc6p7nrq7h",
   },
   "go.testFlags": ["-v", "-count=1"]
}

• In your VS code terminal log in to your cluster.
• Run or Debug the test.

Other Considerations

• Testing on an OSD cluster the test fails as the current instascale functionality creates machine pools but then deletes the underlying machines, leaving behind the machine pools.
• Testing on an OSD cluster on top of this PR the test passes as the updated instascale functionality creates and then deletes the machine pools. Image used: quay.io/rh_ee_fwaters/instascale-controller:test

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change